Login | Register
My pages Projects Community openCollabNet

Discussions > cvs > CVS update: /insurrection/src/

Project highlights: A modern, light-weight, self-contained, web-based toolset for Subversion repository browsing and administration.  A live system can be seen in action here.

insurrection
Discussion topic

Back to topic list

CVS update: /insurrection/src/

Author mksoft
Full name Michae Sinz
Date 2006-03-08 12:50:38 PST
Message User: mksoft
Date: 2006/03/08 12:50:38

Modified:
   insurrection/src/admin.cgi

Log:
 Synced up to r321
 
 This is rather important!
 
 Fixed the amazingly stupid mistake in the checking of the user name
 for making new users. Wow! The check basically so bad that it was
 hard to find a name that was not illegal!
 
 The conditional should have been "&&" to check both the characters *and*
 the length limit. I had it as "||" which basically made it such that
 it would only prevent names that were both too long and invalid rather than
 either too long or invalid!
 
 (What a blunder... where is that paper bag...)

File Changes:

Directory: /insurrection/src/
=============================

File [changed]: admin.cgi
Url: http://insurrection.​tigris.org/source/br​owse/insurrection/sr​c/admin.cgi?r1=1.29​&r2=1.30
Delta lines: +3 -3
-------------------
--- admin.cgi 28 Sep 2005 16:24:22 -0000 1.29
+++ admin.cgi 8 Mar 2006 20:50:35 -0000 1.30
@@ -1,6 +1,6 @@
 #!/usr/bin/perl
 #
-# $Id: admin.cgi,v 1.29 2005/09/28 16:24:22 mksoft Exp $
+# $Id: admin.cgi,v 1.30 2006/03/08 20:50:35 mksoft Exp $
 # Copyright 2004,2005 - Michael Sinz
 #
 # This script handles the various administrative
@@ -183,7 +183,7 @@
 
    ## Only simple characters in the user name and nothing too long
    ## Ok, we picked the size limit out of thin air but it is a reasonable limit.
- if (($user =~ /^[a-z][-.@a-z0-9_]+$/o) || (length($user) < 64))
+ if (($user =~ /^[a-z][-.@a-z0-9_]+$/o) && (length($user) < 64))
    {
 
       ## Lock the password file...
@@ -303,7 +303,7 @@
 
 print '</center>';
 
-&svn_TRAILER('$Id: admin.cgi,v 1.29 2005/09/28 16:24:22 mksoft Exp $');
+&svn_TRAILER('$Id: admin.cgi,v 1.30 2006/03/08 20:50:35 mksoft Exp $');
 
 sub printAdminForms()
 {

« Previous message in topic | 1 of 1 | Next message in topic »

Messages

Show all messages in topic

CVS update: /insurrection/src/ mksoft Michae Sinz 2006-03-08 12:50:38 PST
Messages per page: